Include weak dependencies of Ruby that we actually need #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Checked commit Fryguy@b83bec6 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
bdunne
added a commit
to bdunne/manageiq-rpm_build
that referenced
this pull request
Jul 10, 2024
Include weak dependencies of Ruby that we actually need (cherry picked from commit 97aa8f9) Modified to remove ruby-default-gems since that does not exist in this version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ruby module declares a number of dependencies as weak dependencies, including: ruby-default-gems, rubygem-bigdecimal, rubygem-io-console, and rubygem-rdoc. Additionally, rubygem-irb is considered weak as it's a dependency of rubygem-rdoc.
If weak dependencies are excluded, these will not be installed, but ManageIQ depends on them, so this change makes the ones we need actually required. The PR does not require the following weak gems as we either don't need them or have newer versions in the gemset: rubygem-bundler-2.2.24, rubygem-json-2.3.0, and rubygem-rdoc-6.2.1.1
This can be merged independently of ManageIQ/manageiq-pods#846